Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 13521002: Remove \r in command stdout/stderr when building failure a failure output. (Closed)

Created:
7 years, 8 months ago by kustermann
Modified:
7 years, 8 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Remove \r in command stdout/stderr when building failure a failure output. BUG=http://dartbug.com/8704 Committed: https://code.google.com/p/dart/source/detail?r=20860

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M tools/testing/dart/test_progress.dart View 1 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kustermann
7 years, 8 months ago (2013-04-03 08:56:22 UTC) #1
ahe
LGTM! https://codereview.chromium.org/13521002/diff/1/tools/testing/dart/test_progress.dart File tools/testing/dart/test_progress.dart (right): https://codereview.chromium.org/13521002/diff/1/tools/testing/dart/test_progress.dart#newcode102 tools/testing/dart/test_progress.dart:102: .replaceAll('\r\n', '\n').split('\n')); How about creating a method for ...
7 years, 8 months ago (2013-04-03 10:13:58 UTC) #2
kustermann
https://codereview.chromium.org/13521002/diff/1/tools/testing/dart/test_progress.dart File tools/testing/dart/test_progress.dart (right): https://codereview.chromium.org/13521002/diff/1/tools/testing/dart/test_progress.dart#newcode102 tools/testing/dart/test_progress.dart:102: .replaceAll('\r\n', '\n').split('\n')); On 2013/04/03 10:13:58, ahe wrote: > How ...
7 years, 8 months ago (2013-04-03 12:52:13 UTC) #3
kustermann
7 years, 8 months ago (2013-04-03 13:21:03 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r20860 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698