Generate non-dart assets from “lib” into the build output.

Generate non-dart assets from “lib” into the build output.

BUG=https://code.google.com/p/dart/issues/detail?id=16642
R=nweiz@google.com

Committed: https://code.google.com/p/dart/source/detail?r=32534

[nweiz, 2014-02-10 21:48:18]

https://codereview.chromium.org/135153012/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/command/build.dart (right):

https://codereview.chromium.org/135153012/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/command/build.dart:229: .map((relative) =>
path.dirname(relative))
Why are we double-mapping here rather than doing
path.dirname(path.joinAll(path.url.split(id.path))) all in one line?

https://codereview.chromium.org/135153012/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/command/build.dart:231: // lib asset copying will
take care of that.
This comment is confusing. I suggest "Don't copy files to the top levels of the
build directories since ...".

https://codereview.chromium.org/135153012/diff/1/sdk/lib/_internal/pub/test/b...
File
sdk/lib/_internal/pub/test/build/includes_assets_from_dependencies_in_lib_test.dart
(right):

https://codereview.chromium.org/135153012/diff/1/sdk/lib/_internal/pub/test/b...
sdk/lib/_internal/pub/test/build/includes_assets_from_dependencies_in_lib_test.dart:13:
integration("includes assets from the 'lib' directory of dependencies", () {
We should also have a test that these *aren't* included anywhere but the top
level.

[Bob Nystrom, 2014-02-10 23:12:29]

Thanks!

https://codereview.chromium.org/135153012/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/command/build.dart (right):

https://codereview.chromium.org/135153012/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/command/build.dart:229: .map((relative) =>
path.dirname(relative))
On 2014/02/10 21:48:18, nweiz wrote:
> Why are we double-mapping here rather than doing
> path.dirname(path.joinAll(path.url.split(id.path))) all in one line?

Not sure. Fixed.

https://codereview.chromium.org/135153012/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/command/build.dart:231: // lib asset copying will
take care of that.
On 2014/02/10 21:48:18, nweiz wrote:
> This comment is confusing. I suggest "Don't copy files to the top levels of
the
> build directories since ...".

Done.

https://codereview.chromium.org/135153012/diff/1/sdk/lib/_internal/pub/test/b...
File
sdk/lib/_internal/pub/test/build/includes_assets_from_dependencies_in_lib_test.dart
(right):

https://codereview.chromium.org/135153012/diff/1/sdk/lib/_internal/pub/test/b...
sdk/lib/_internal/pub/test/build/includes_assets_from_dependencies_in_lib_test.dart:13:
integration("includes assets from the 'lib' directory of dependencies", () {
On 2014/02/10 21:48:18, nweiz wrote:
> We should also have a test that these *aren't* included anywhere but the top
> level.

Done. Added to this test.

[nweiz, 2014-02-10 23:17:31]

lgtm

[Bob Nystrom, 2014-02-11 01:19:48]

Committed patchset #2 manually as r32534 (presubmit successful).