Issue 13515004: Remove pseudo-shared Timer implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13515004: Remove pseudo-shared Timer implementation. (Closed)

Created:
7 years, 8 months ago by Anton Muhin

Modified:
7 years, 8 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove pseudo-shared Timer implementation. R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=20962

Patch Set 1 #

Total comments: 1

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+118 lines, -192 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	1 chunk	+0 lines, -63 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	2 chunks	+59 lines, -63 lines	0 comments	Download
D	tools/dom/src/Timer.dart	View	1 chunk	+0 lines, -64 lines	0 comments	Download
M	tools/dom/src/native_DOMImplementation.dart	View	1 chunk	+59 lines, -0 lines	1 comment	Download
M	tools/dom/templates/html/dart2js/html_dart2js.darttemplate	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tools/dom/templates/html/dartium/html_dartium.darttemplate	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

vsm

lgtm https://codereview.chromium.org/13515004/diff/1/tools/dom/src/native_DOMImplementation.dart File tools/dom/src/native_DOMImplementation.dart (right): https://codereview.chromium.org/13515004/diff/1/tools/dom/src/native_DOMImplementation.dart#newcode200 tools/dom/src/native_DOMImplementation.dart:200: get _timerFactoryClosure => (int milliSeconds, void callback(Timer timer), ...

7 years, 8 months ago (2013-04-04 13:41:49 UTC) #3

Anton Muhin

7 years, 8 months ago (2013-04-05 12:33:19 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r20962 (presubmit successful).

Expand Messages | Collapse Messages