Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(910)

Issue 1351323004: Add '<!doctype html>' to spec. (Closed)

Created:
5 years, 3 months ago by scheglov
Modified:
5 years, 3 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add '<!doctype html>' to spec. The new task model's HTML parser reports an error otherwise. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/173cb44a85d0f1441fa5e5e5b26a7365baa09c3d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M pkg/analysis_server/doc/api.html View 2 chunks +5 lines, -2 lines 0 comments Download
M pkg/analysis_server/tool/spec/from_html.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/analysis_server/tool/spec/to_html.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
5 years, 3 months ago (2015-09-21 16:56:30 UTC) #1
Paul Berry
lgtm
5 years, 3 months ago (2015-09-21 16:58:39 UTC) #2
Brian Wilkerson
LGTM
5 years, 3 months ago (2015-09-21 17:04:27 UTC) #3
scheglov
5 years, 3 months ago (2015-09-21 17:11:02 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
173cb44a85d0f1441fa5e5e5b26a7365baa09c3d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698