Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1351243003: Fix status pages when running new task model (Closed)

Created:
5 years, 3 months ago by Brian Wilkerson
Modified:
5 years, 3 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Clean up #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -44 lines) Patch
M pkg/analysis_server/lib/src/status/get_handler.dart View 1 12 chunks +18 lines, -34 lines 2 comments Download
M pkg/analyzer/lib/src/context/cache.dart View 2 chunks +11 lines, -10 lines 0 comments Download
M pkg/analyzer/lib/src/generated/constant.dart View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Brian Wilkerson
5 years, 3 months ago (2015-09-22 17:55:13 UTC) #2
scheglov
LGTM https://codereview.chromium.org/1351243003/diff/20001/pkg/analysis_server/lib/src/status/get_handler.dart File pkg/analysis_server/lib/src/status/get_handler.dart (right): https://codereview.chromium.org/1351243003/diff/20001/pkg/analysis_server/lib/src/status/get_handler.dart#newcode766 pkg/analysis_server/lib/src/status/get_handler.dart:766: Source target = iterator.key; Do you mean "AnalysisTarget ...
5 years, 3 months ago (2015-09-22 18:00:38 UTC) #3
Brian Wilkerson
Committed patchset #2 (id:20001) manually as 163ad75127573805c4778d3847194f2ade487e2e (presubmit successful).
5 years, 3 months ago (2015-09-22 18:04:00 UTC) #4
Brian Wilkerson
5 years, 3 months ago (2015-09-22 18:04:16 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/1351243003/diff/20001/pkg/analysis_server/lib...
File pkg/analysis_server/lib/src/status/get_handler.dart (right):

https://codereview.chromium.org/1351243003/diff/20001/pkg/analysis_server/lib...
pkg/analysis_server/lib/src/status/get_handler.dart:766: Source target =
iterator.key;
Yes. Done.

Powered by Google App Engine
This is Rietveld 408576698