Issue 1350993002: Reset AnalysisDriver on priority sources changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1350993002: Reset AnalysisDriver on priority sources changes. (Closed)

Created:
5 years, 3 months ago by scheglov

Modified:
5 years, 3 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Reset AnalysisDriver on priority sources changes. It turned out that our WorkManager(s) don't have the problem we discussed. We remove targeted results from queues only when they are VALID or ERROR. So, reset is safe to do. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/ff95a65900ea3bdd96797f1580cc5f4b79eeb5b4

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -7 lines)			Patch
M	pkg/analyzer/lib/src/context/context.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/analyzer/lib/task/model.dart	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	pkg/analyzer/test/src/context/context_test.dart	View	5 chunks	+20 lines, -7 lines	0 comments	Download

Total messages: 3 (0 generated)

scheglov

5 years, 3 months ago (2015-09-17 14:57:57 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ff95a65900ea3bdd96797f1580cc5f4b79eeb5b4 (presubmit successful).