Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1350933002: Stop using parts. (Closed)

Created:
5 years, 3 months ago by nweiz
Modified:
5 years, 3 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org, sethladd
Base URL:
git@github.com:dart-lang/crypto.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+274 lines, -384 lines) Patch
M lib/crypto.dart View 1 chunk +6 lines, -98 lines 0 comments Download
M lib/src/base64.dart View 1 chunk +4 lines, -1 line 0 comments Download
M lib/src/crypto_utils.dart View 2 chunks +36 lines, -2 lines 0 comments Download
A lib/src/hash.dart View 1 chunk +45 lines, -0 lines 0 comments Download
A + lib/src/hash_base.dart View 5 chunks +30 lines, -43 lines 2 comments Download
D lib/src/hash_utils.dart View 1 chunk +0 lines, -150 lines 0 comments Download
M lib/src/hmac.dart View 1 chunk +3 lines, -1 line 0 comments Download
M lib/src/md5.dart View 3 chunks +34 lines, -22 lines 0 comments Download
M lib/src/sha1.dart View 1 chunk +40 lines, -28 lines 0 comments Download
M lib/src/sha256.dart View 4 chunks +51 lines, -39 lines 0 comments Download
A lib/src/utils.dart View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
nweiz
5 years, 3 months ago (2015-09-16 21:11:22 UTC) #2
Bob Nystrom
https://codereview.chromium.org/1350933002/diff/1/lib/src/hash_base.dart File lib/src/hash_base.dart (right): https://codereview.chromium.org/1350933002/diff/1/lib/src/hash_base.dart#newcode20 lib/src/hash_base.dart:20: final Uint32List h; Is this now publicly exposed outside ...
5 years, 3 months ago (2015-09-16 21:18:35 UTC) #3
nweiz
https://codereview.chromium.org/1350933002/diff/1/lib/src/hash_base.dart File lib/src/hash_base.dart (right): https://codereview.chromium.org/1350933002/diff/1/lib/src/hash_base.dart#newcode20 lib/src/hash_base.dart:20: final Uint32List h; On 2015/09/16 21:18:35, Bob Nystrom wrote: ...
5 years, 3 months ago (2015-09-16 21:21:33 UTC) #4
Bob Nystrom
LGTM!
5 years, 3 months ago (2015-09-16 21:21:58 UTC) #5
nweiz
5 years, 3 months ago (2015-09-16 21:22:29 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
b77eba1d4b56f917e6003a01c95d9d78c8654098 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698