Issue 1350913002: Run the formatter over crypto.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1350913002: Run the formatter over crypto. (Closed)

Created:
5 years, 3 months ago by nweiz

Modified:
5 years, 3 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/crypto.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Run the formatter over crypto. This also includes some handmade formatting of large data blocks, but no non-whitespace changes. R=rnystrom@google.com Committed: https://github.com/dart-lang/crypto/commit/308e8be46ff2d46a15540a5bca353089bc7ecdb0

Patch Set 2 : Remove HMAC.rsp. #

Total comments: 1

Patch Set 3 : Fix a missing value. #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+586 lines, -553 lines)			Patch
M	lib/crypto.dart	View	1	1 chunk	+2 lines, -6 lines	0 comments	Download
M	lib/src/base64.dart	View	1	14 chunks	+60 lines, -70 lines	0 comments	Download
M	lib/src/crypto_utils.dart	View	1	1 chunk	+2 lines, -4 lines	0 comments	Download
M	lib/src/hash_utils.dart	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download
M	lib/src/hmac.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/src/md5.dart	View	1	3 chunks	+10 lines, -9 lines	0 comments	Download
M	lib/src/sha1.dart	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	lib/src/sha256.dart	View	1	4 chunks	+21 lines, -18 lines	0 comments	Download
M	test/base64_test.dart	View	1	8 chunks	+107 lines, -96 lines	0 comments	Download
M	test/hmac_md5_test.dart	View	1 2	1 chunk	+119 lines, -84 lines	0 comments	Download
M	test/hmac_sha1_test.dart	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	test/hmac_sha256_test.dart	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/sha1_test.dart	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	test/sha256_test.dart	View	1	2 chunks	+257 lines, -257 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

LGTM! https://codereview.chromium.org/1350913002/diff/10001/lib/src/base64.dart File lib/src/base64.dart (right): https://codereview.chromium.org/1350913002/diff/10001/lib/src/base64.dart#newcode329 lib/src/base64.dart:329: for (int i = 0, o = 0; ...

5 years, 3 months ago (2015-09-16 20:45:23 UTC) #2

nweiz

5 years, 3 months ago (2015-09-16 21:09:58 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 (id:30001) manually as
308e8be46ff2d46a15540a5bca353089bc7ecdb0 (presubmit successful).