Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1350903008: Fixed typo and test that passes and fails in checked mode (Closed)

Created:
5 years, 3 months ago by terry
Modified:
5 years, 3 months ago
Reviewers:
Alan Knight
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fixed typo and test that passes and fails in checked mode TBR=alanknight@google.com Committed: https://github.com/dart-lang/sdk/commit/847847dd952cb83351b6b2173bb8d29b1b674658

Patch Set 1 #

Patch Set 2 : Merged #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M sdk/lib/html/html_common/conversions_dartium.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/co19/co19-dartium.status View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
terry
Committed patchset #2 (id:20001) manually as 847847dd952cb83351b6b2173bb8d29b1b674658 (presubmit successful).
5 years, 3 months ago (2015-09-22 14:59:45 UTC) #1
Alan Knight
5 years, 3 months ago (2015-09-22 16:16:24 UTC) #2
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698