Issue 1350553004: Improve the style of tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1350553004: Improve the style of tests. (Closed)

Created:
5 years, 3 months ago by nweiz

Modified:
5 years, 3 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/crypto.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Improve the style of tests. R=rnystrom@google.com Committed: https://github.com/dart-lang/crypto/commit/193d3dcb6ebe7f502bf20af16476c6c9652078d9

Patch Set 1 #

Total comments: 1

Created: 5 years, 3 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+1940 lines, -2349 lines)			Patch
M	lib/crypto.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	test/base64_test.dart	View	1 chunk	+287 lines, -287 lines	0 comments	Download
M	test/hmac_md5_test.dart	View	2 chunks	+25 lines, -128 lines	0 comments	Download
M	test/hmac_sha1_test.dart	View	1 chunk	+918 lines, -11 lines	1 comment	Download
D	test/hmac_sha1_test_vectors.dart	View	1 chunk	+0 lines, -917 lines	0 comments	Download
M	test/hmac_sha256_test.dart	View	1 chunk	+693 lines, -12 lines	0 comments	Download
D	test/hmac_sha256_test_vectors.dart	View	1 chunk	+0 lines, -692 lines	0 comments	Download
D	test/sha1_short_test_vectors.dart	View	1 chunk	+0 lines, -144 lines	0 comments	Download
D	test/sha256_short_test_vectors.dart	View	1 chunk	+0 lines, -144 lines	0 comments	Download
A	test/utils.dart	View	1 chunk	+16 lines, -0 lines	0 comments	Download
D	test/very_long_input.dart	View	1 chunk	+0 lines, -14 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

LGTM! I remember these files. They used to crash dartfmt. https://codereview.chromium.org/1350553004/diff/1/test/hmac_sha1_test.dart File test/hmac_sha1_test.dart (right): https://codereview.chromium.org/1350553004/diff/1/test/hmac_sha1_test.dart#newcode617 ...

5 years, 3 months ago (2015-09-21 22:01:06 UTC) #2

nweiz

5 years, 3 months ago (2015-09-21 22:35:08 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
193d3dcb6ebe7f502bf20af16476c6c9652078d9 (presubmit successful).

Expand Messages | Collapse Messages