Add the ability to secure an already established raw socket connection

Add the ability to secure an already established raw socket connection

The static methods secure and secureServer can be used to start
TLS handshake as eihter client or server.

This CL only implement the securing of RawSocket.

This also changes the semantics of cancelling a subscription on a
RawSocket from closing the socket to just pausing.

R=ager@google.com

BUG=https://code.google.com/p/dart/issues/detail?id=8789

Committed: https://code.google.com/p/dart/source/detail?r=21719

[Mads Ager (google), 2013-04-03 15:26:55]

LGTM

https://codereview.chromium.org/13502004/diff/2001/runtime/bin/socket_patch.dart
File runtime/bin/socket_patch.dart (right):

https://codereview.chromium.org/13502004/diff/2001/runtime/bin/socket_patch.d...
runtime/bin/socket_patch.dart:613: _pause();
So, this means that listening on a socket and cancelling the subscription no
longer corresponds to a close for read? We should make sure to document what an
unsubscription means for all of our sockets. I think I replied to an email
thread yesterday stating that an unsubscription is a half-close. :-)

https://codereview.chromium.org/13502004/diff/2001/sdk/lib/io/secure_socket.dart
File sdk/lib/io/secure_socket.dart (right):

https://codereview.chromium.org/13502004/diff/2001/sdk/lib/io/secure_socket.d...
sdk/lib/io/secure_socket.dart:155: * Make sure that any subscription for
[RawSocketEvent] evnets on
evnets -> events.

https://codereview.chromium.org/13502004/diff/2001/sdk/lib/io/secure_socket.d...
sdk/lib/io/secure_socket.dart:156: * the [socket] is canceled before calling
this function.
cancelled

https://codereview.chromium.org/13502004/diff/2001/tests/standalone/io/raw_se...
File tests/standalone/io/raw_secure_server_socket_test.dart (right):

https://codereview.chromium.org/13502004/diff/2001/tests/standalone/io/raw_se...
tests/standalone/io/raw_secure_server_socket_test.dart:139: //
Move 'fully.' up here and have the empty line after that?

[Søren Gjesse, 2013-04-19 05:17:09]

PTAL

Changed the API to take a subscription of already subscribed. On the server side
one can also pass initial data from the TLS handshake if already read.

https://codereview.chromium.org/13502004/diff/2001/runtime/bin/socket_patch.dart
File runtime/bin/socket_patch.dart (right):

https://codereview.chromium.org/13502004/diff/2001/runtime/bin/socket_patch.d...
runtime/bin/socket_patch.dart:613: _pause();
On 2013/04/03 15:26:55, Mads Ager wrote:
> So, this means that listening on a socket and cancelling the subscription no
> longer corresponds to a close for read? We should make sure to document what
an
> unsubscription means for all of our sockets. I think I replied to an email
> thread yesterday stating that an unsubscription is a half-close. :-)

After discussing this with Florian I reverted, and is now passing the
subscription when securing an already subscribed to socket.

https://codereview.chromium.org/13502004/diff/2001/sdk/lib/io/secure_socket.dart
File sdk/lib/io/secure_socket.dart (right):

https://codereview.chromium.org/13502004/diff/2001/sdk/lib/io/secure_socket.d...
sdk/lib/io/secure_socket.dart:155: * Make sure that any subscription for
[RawSocketEvent] evnets on
On 2013/04/03 15:26:55, Mads Ager wrote:
> evnets -> events.

Done

https://codereview.chromium.org/13502004/diff/2001/sdk/lib/io/secure_socket.d...
sdk/lib/io/secure_socket.dart:156: * the [socket] is canceled before calling
this function.
On 2013/04/03 15:26:55, Mads Ager wrote:
> cancelled

Done.

https://codereview.chromium.org/13502004/diff/2001/tests/standalone/io/raw_se...
File tests/standalone/io/raw_secure_server_socket_test.dart (right):

https://codereview.chromium.org/13502004/diff/2001/tests/standalone/io/raw_se...
tests/standalone/io/raw_secure_server_socket_test.dart:139: //
On 2013/04/03 15:26:55, Mads Ager wrote:
> Move 'fully.' up here and have the empty line after that?

Done.

[Mads Ager (google), 2013-04-19 05:28:19]

LGTM!

https://codereview.chromium.org/13502004/diff/9001/sdk/lib/io/secure_socket.dart
File sdk/lib/io/secure_socket.dart (right):

https://codereview.chromium.org/13502004/diff/9001/sdk/lib/io/secure_socket.d...
sdk/lib/io/secure_socket.dart:185: * If the [socket] is already subscribed to
pass the existing
is already subscribed to -> already has a subscription?

(if you change, it should change above as well)

https://codereview.chromium.org/13502004/diff/9001/sdk/lib/io/secure_socket.d...
sdk/lib/io/secure_socket.dart:351: // If a current subscription is provided use
this otherwise
indentation

[Søren Gjesse, 2013-04-19 07:37:46]

Committed patchset #4 manually as r21719 (presubmit successful).