Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 1349723002: dart2js cps: Set result of 'await' to dynamic instead of empty. (Closed)

Created:
5 years, 3 months ago by asgerf
Modified:
5 years, 3 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Set result of 'await' to dynamic instead of empty. BUG= R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/ccb3af54ab0aceb680f62eb834c7df4624f931d2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/language/language_dart2js.status View 3 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
asgerf
This fixes some tests and causes others to fail. My best guess is that the ...
5 years, 3 months ago (2015-09-16 13:45:27 UTC) #2
karlklose
LGTM.
5 years, 3 months ago (2015-09-17 09:40:19 UTC) #3
asgerf
5 years, 3 months ago (2015-09-21 09:37:44 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ccb3af54ab0aceb680f62eb834c7df4624f931d2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698