Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 134963007: Fix a flaky test and work around issue 16003 in pkg/watcher. (Closed)

Created:
6 years, 11 months ago by nweiz
Modified:
6 years, 11 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix a flaky test and work around issue 16003 in pkg/watcher. There's an additional flaky test that this CL is not likely to fix. Additional debugging is added to help track down the cause of that flake. R=rnystrom@google.com BUG=16079 Committed: https://code.google.com/p/dart/source/detail?r=31815

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -37 lines) Patch
M pkg/watcher/lib/src/directory_watcher/mac_os.dart View 7 chunks +25 lines, -13 lines 2 comments Download
M pkg/watcher/test/directory_watcher/mac_os_test.dart View 1 chunk +21 lines, -22 lines 0 comments Download
M pkg/watcher/test/utils.dart View 8 chunks +21 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nweiz
6 years, 11 months ago (2014-01-14 23:40:48 UTC) #1
Bob Nystrom
Passes on my machine. One fix then LGTM. https://codereview.chromium.org/134963007/diff/1/pkg/watcher/lib/src/directory_watcher/mac_os.dart File pkg/watcher/lib/src/directory_watcher/mac_os.dart (right): https://codereview.chromium.org/134963007/diff/1/pkg/watcher/lib/src/directory_watcher/mac_os.dart#newcode365 pkg/watcher/lib/src/directory_watcher/mac_os.dart:365: print("[$_id] ...
6 years, 11 months ago (2014-01-14 23:45:09 UTC) #2
nweiz
https://codereview.chromium.org/134963007/diff/1/pkg/watcher/lib/src/directory_watcher/mac_os.dart File pkg/watcher/lib/src/directory_watcher/mac_os.dart (right): https://codereview.chromium.org/134963007/diff/1/pkg/watcher/lib/src/directory_watcher/mac_os.dart#newcode365 pkg/watcher/lib/src/directory_watcher/mac_os.dart:365: print("[$_id] stream closed"); On 2014/01/14 23:45:09, Bob Nystrom wrote: ...
6 years, 11 months ago (2014-01-14 23:49:07 UTC) #3
nweiz
6 years, 11 months ago (2014-01-14 23:49:19 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r31815 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698