Issue 134963002: pkg/unittest: add @proxy to Mock

Issue 134963002: pkg/unittest: add @proxy to Mock (Closed)

Created:
6 years, 11 months ago by kevmoo

Modified:
6 years, 11 months ago

Reviewers:
Bob Nystrom, Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

pkg/unittest: add @proxy to Mock Also: fixed analyzer errors BUG= https://code.google.com/p/dart/issues/detail?id=13099 R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=31725

Patch Set 2 : nits #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -3 lines)			Patch
M	pkg/pkg.status	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/unittest/lib/mock.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/unittest/test/mock_test.dart	View		3 chunks	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

https://codereview.chromium.org/134963002/diff/1/pkg/unittest/test/matchers_test.dart File pkg/unittest/test/matchers_test.dart (right): https://codereview.chromium.org/134963002/diff/1/pkg/unittest/test/matchers_test.dart#newcode763 pkg/unittest/test/matchers_test.dart:763: break; I think the idea of this test was ...

6 years, 11 months ago (2014-01-10 23:23:32 UTC) #2

kevmoo

PTAL https://codereview.chromium.org/134963002/diff/1/pkg/unittest/test/matchers_test.dart File pkg/unittest/test/matchers_test.dart (right): https://codereview.chromium.org/134963002/diff/1/pkg/unittest/test/matchers_test.dart#newcode763 pkg/unittest/test/matchers_test.dart:763: break; On 2014/01/10 23:23:32, Siggi Cherem (dart-lang) wrote: ...

6 years, 11 months ago (2014-01-10 23:37:45 UTC) #3

kevmoo

6 years, 11 months ago (2014-01-11 01:48:09 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r31725 (presubmit successful).

Expand Messages | Collapse Messages