Improve the style of code in lib/.

Improve the style of code in lib/.

This also improves some implementations, especially to make better use
of typed data.

R=rnystrom@google.com

Committed: https://github.com/dart-lang/crypto/commit/ff5295af5d1d112d2cf35a45f25217cc93bcb38f

[nweiz, 2015-09-18 01:19:16]

nweiz@google.com changed reviewers:
+ rnystrom@google.com

[Bob Nystrom, 2015-09-18 17:15:48]

I didn't review this in detail because I'm assuming it's mostly moving code and
renaming variables.

LGTM.

https://codereview.chromium.org/1349373002/diff/1/lib/src/base64/decoder.dart
File lib/src/base64/decoder.dart (right):

https://codereview.chromium.org/1349373002/diff/1/lib/src/base64/decoder.dart...
lib/src/base64/decoder.dart:78: input.codeUnitAt(i - 2) == $percent) {
Nit, but I think it would be a bit easier to read if the last two cases were
swapped:

input.codeUnitAt(i - 2) == $percent &&
input.codeUnitAt(i - 1) == $3

https://codereview.chromium.org/1349373002/diff/1/lib/src/hash_base.dart
File lib/src/hash_base.dart (right):

https://codereview.chromium.org/1349373002/diff/1/lib/src/hash_base.dart#newc...
lib/src/hash_base.dart:56: void updateHash(Uint32List m);
"m" -> "chunk"?

https://codereview.chromium.org/1349373002/diff/1/lib/src/utils.dart
File lib/src/utils.dart (right):

https://codereview.chromium.org/1349373002/diff/1/lib/src/utils.dart#newcode8
lib/src/utils.dart:8: const mask32 = 0XFFFFFFFF;
Lowercase "x".

[nweiz, 2015-09-18 19:37:21]

https://codereview.chromium.org/1349373002/diff/1/lib/src/base64/decoder.dart
File lib/src/base64/decoder.dart (right):

https://codereview.chromium.org/1349373002/diff/1/lib/src/base64/decoder.dart...
lib/src/base64/decoder.dart:78: input.codeUnitAt(i - 2) == $percent) {
On 2015/09/18 17:15:48, Bob Nystrom wrote:
> Nit, but I think it would be a bit easier to read if the last two cases were
> swapped:
> 
> input.codeUnitAt(i - 2) == $percent &&
> input.codeUnitAt(i - 1) == $3

Done.

https://codereview.chromium.org/1349373002/diff/1/lib/src/hash_base.dart
File lib/src/hash_base.dart (right):

https://codereview.chromium.org/1349373002/diff/1/lib/src/hash_base.dart#newc...
lib/src/hash_base.dart:56: void updateHash(Uint32List m);
On 2015/09/18 17:15:48, Bob Nystrom wrote:
> "m" -> "chunk"?

Done.

https://codereview.chromium.org/1349373002/diff/1/lib/src/utils.dart
File lib/src/utils.dart (right):

https://codereview.chromium.org/1349373002/diff/1/lib/src/utils.dart#newcode8
lib/src/utils.dart:8: const mask32 = 0XFFFFFFFF;
On 2015/09/18 17:15:48, Bob Nystrom wrote:
> Lowercase "x".

Done.

[nweiz, 2015-09-18 19:37:53]

Code review changes

[nweiz, 2015-09-18 19:38:29]

Committed patchset #2 (id:20001) manually as
ff5295af5d1d112d2cf35a45f25217cc93bcb38f (presubmit successful).