Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 13493020: lib/utf: remove codepointsToString (Closed)

Created:
7 years, 8 months ago by kevmoo-old
Modified:
7 years, 8 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

lib/utf: remove codepointsToString point folks to use String.fromCharCodes Committed: https://code.google.com/p/dart/source/detail?r=21151

Patch Set 1 #

Total comments: 2

Patch Set 2 : nits, moved tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -70 lines) Patch
M pkg/source_maps/lib/span.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/utf/utf.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/utf/utf32.dart View 1 3 chunks +5 lines, -5 lines 0 comments Download
M sdk/lib/utf/utf8.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/lib/utf/utf8_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib/utf/utf_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
D tests/utils/utf8_test.dart View 1 1 chunk +0 lines, -47 lines 0 comments Download
M tests/utils/utf_test.dart View 1 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kevmoo-old
Seems a bit redundant to have this method which just calls String in core I'd ...
7 years, 8 months ago (2013-04-08 20:03:08 UTC) #1
nweiz
LGTM, although I don't have any particular knowledge of any of the code it touches. ...
7 years, 8 months ago (2013-04-08 20:41:19 UTC) #2
Siggi Cherem (dart-lang)
+floitsch, lrn - if they don't own this code, they should know who does =)
7 years, 8 months ago (2013-04-08 20:57:39 UTC) #3
floitsch
LGTM, but this change will be temporary. The unicode library is on my list of ...
7 years, 8 months ago (2013-04-08 21:09:26 UTC) #4
kevmoo-old
7 years, 8 months ago (2013-04-09 13:51:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r21151 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698