Issue 13493011: Fix some tests.

Issue 13493011: Fix some tests. (Closed)

Created:
7 years, 8 months ago by floitsch

Modified:
7 years, 8 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix some tests. Committed: https://code.google.com/p/dart/source/detail?r=21081

Patch Set 1 #

Total comments: 4

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -3 lines)			Patch
M	samples/tests/samples/lib/layout/layout_test.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/compiler/dart2js/call_site_simple_type_inferer_test.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/compiler/dart2js/constant_namer_test.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/compiler/dart2js/deferred_load_graph_segmentation_test.dart	View	2 chunks	+2 lines, -1 line	2 comments	Download
M	tests/compiler/dart2js/field_type_simple_inferer_test.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/compiler/dart2js/interpolation_folding_test.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/compiler/dart2js/js_parser_test.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/compiler/dart2js/literal_map_test.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/compiler/dart2js/mirrors_metadata_test.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/compiler/dart2js/resolution_test.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/compiler/dart2js/simple_inferrer_and_or_test.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/compiler/dart2js/simple_inferrer_closure_test.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/compiler/dart2js/simple_inferrer_final_field2_test.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/compiler/dart2js/simple_inferrer_final_field3_test.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/compiler/dart2js/simple_inferrer_final_field_test.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/compiler/dart2js/simple_inferrer_postfix_prefix_test.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/compiler/dart2js/simple_inferrer_test.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/compiler/dart2js/simple_inferrer_try_catch_test.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/compiler/dart2js/size_test.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/compiler/dart2js/subtype_test.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/compiler/dart2js/tag_mapping_test.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/compiler/dart2js/type_representation_test.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/compiler/dart2js/type_test_helper.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/compiler/dart2js/type_variable_occurrence_test.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/compiler/dart2js/types_of_captured_variables_test.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/standalone/io/windows_environment_test.dart	View	2 chunks	+1 line, -2 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

floitsch

Committed patchset #1 manually as r21081 (presubmit successful).

7 years, 8 months ago (2013-04-08 16:34:44 UTC) #2

ngeoffray

LGTM https://codereview.chromium.org/13493011/diff/1/tests/compiler/dart2js/deferred_load_graph_segmentation_test.dart File tests/compiler/dart2js/deferred_load_graph_segmentation_test.dart (right): https://codereview.chromium.org/13493011/diff/1/tests/compiler/dart2js/deferred_load_graph_segmentation_test.dart#newcode90 tests/compiler/dart2js/deferred_load_graph_segmentation_test.dart:90: if (42 != new MyClass().foo(87)) throw "not equal"; ...

7 years, 8 months ago (2013-04-10 09:49:44 UTC) #3

floitsch

7 years, 8 months ago (2013-04-10 10:46:10 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/13493011/diff/1/tests/compiler/dart2js/deferr...
File tests/compiler/dart2js/deferred_load_graph_segmentation_test.dart (right):

https://codereview.chromium.org/13493011/diff/1/tests/compiler/dart2js/deferr...
tests/compiler/dart2js/deferred_load_graph_segmentation_test.dart:90: if (42 !=
new MyClass().foo(87)) throw "not equal";
On 2013/04/10 09:49:44, ngeoffray wrote:
> Why this change if you're importing expect?

This is inside a Dart script that is generated and then read separately. (see
the """ in line 81).
I didn't want to play with package-paths for that.

https://codereview.chromium.org/13493011/diff/1/tests/standalone/io/windows_e...
File tests/standalone/io/windows_environment_test.dart (left):

https://codereview.chromium.org/13493011/diff/1/tests/standalone/io/windows_e...
tests/standalone/io/windows_environment_test.dart:5: import
"package:expect/expect.dart";
On 2013/04/10 09:49:44, ngeoffray wrote:
> Why this change?

This test runs itself (I think) as a separate process.
Didn't want to play with package-paths when launching the test.

Expand Messages | Collapse Messages