Issue 13493010: Fix the build with WEB_AUDIO disabled.

Issue 13493010: Fix the build with WEB_AUDIO disabled. (Closed)

Created:
7 years, 8 months ago by podivilov

Modified:
7 years, 8 months ago

Reviewers:
Anton Muhin

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix the build with WEB_AUDIO disabled. Make sure web_audio_DartResolver.cpp is generated even if WEB_AUDIO is disabled because our gyps depend on it. R=antonm@google.com Committed: https://code.google.com/p/dart/source/detail?r=21182

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -14 lines)			Patch
M	tools/dom/idl/dart/dart.idl	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download
M	tools/dom/scripts/dartdomgenerator.py	View		5 chunks	+6 lines, -8 lines	0 comments	Download
M	tools/dom/scripts/systemhtml.py	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tools/dom/scripts/systemnative.py	View	1	2 chunks	+2 lines, -4 lines	0 comments	Download
M	tools/dom/templates/html/dartium/cpp_resolver.template	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

lgtm https://codereview.chromium.org/13493010/diff/1/tools/dom/scripts/systemnative.py File tools/dom/scripts/systemnative.py (right): https://codereview.chromium.org/13493010/diff/1/tools/dom/scripts/systemnative.py#newcode884 tools/dom/scripts/systemnative.py:884: if not library_name in self._library_headers: this probably should ...

7 years, 8 months ago (2013-04-08 15:51:35 UTC) #2

podivilov

fixed dart.idl as well https://codereview.chromium.org/13493010/diff/1/tools/dom/scripts/systemnative.py File tools/dom/scripts/systemnative.py (right): https://codereview.chromium.org/13493010/diff/1/tools/dom/scripts/systemnative.py#newcode884 tools/dom/scripts/systemnative.py:884: if not library_name in self._library_headers: ...

7 years, 8 months ago (2013-04-09 12:09:23 UTC) #3

podivilov

7 years, 8 months ago (2013-04-10 08:02:00 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r21182 (presubmit successful).

Expand Messages | Collapse Messages