Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 1349293006: Start using the dart2js type conversions in Dartium as well. (Closed)

Created:
5 years, 3 months ago by Alan Knight
Modified:
5 years, 3 months ago
Reviewers:
terry
CC:
reviews_dartlang.org, ricow1
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Start using the dart2js type conversions in Dartium as well. BUG= Committed: https://github.com/dart-lang/sdk/commit/aebb870b1326f77546548c73b842f4791aaf8867

Patch Set 1 #

Patch Set 2 : Merged #

Unified diffs Side-by-side diffs Delta from patch set Stats (+297 lines, -194 lines) Patch
M sdk/lib/html/dartium/html_dartium.dart View 30 chunks +45 lines, -53 lines 0 comments Download
M sdk/lib/html/html_common/conversions.dart View 10 chunks +60 lines, -105 lines 0 comments Download
A sdk/lib/html/html_common/conversions_dart2js.dart View 1 chunk +92 lines, -0 lines 0 comments Download
A sdk/lib/html/html_common/conversions_dartium.dart View 1 chunk +63 lines, -0 lines 0 comments Download
M sdk/lib/html/html_common/html_common.dart View 2 chunks +5 lines, -0 lines 0 comments Download
M sdk/lib/html/html_common/html_common_dart2js.dart View 2 chunks +2 lines, -1 line 0 comments Download
M sdk/lib/indexed_db/dartium/indexed_db_dartium.dart View 6 chunks +10 lines, -10 lines 0 comments Download
M tools/dom/scripts/generator.py View 2 chunks +4 lines, -3 lines 0 comments Download
M tools/dom/scripts/systemnative.py View 2 chunks +4 lines, -2 lines 0 comments Download
M tools/dom/templates/html/dartium/html_dartium.darttemplate View 4 chunks +12 lines, -20 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Alan Knight
TBR
5 years, 3 months ago (2015-09-18 19:24:31 UTC) #2
Alan Knight
5 years, 3 months ago (2015-09-18 19:44:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
aebb870b1326f77546548c73b842f4791aaf8867 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698