Don't assume 32-bit message bit lengths.

Don't assume 32-bit message bit lengths.

Issue #14

R=iposva@google.com

Committed: https://github.com/dart-lang/crypto/commit/113e82096fc0cc5a3c190607cfe88184a36d0ffb

[rmacnak, 2015-09-17 19:39:12]

rmacnak@google.com changed reviewers:
+ iposva@google.com, sethladd@google.com

[Ivan Posva, 2015-09-17 19:48:11]

LGTM

-Ivan

https://codereview.chromium.org/1349293002/diff/1/lib/src/hash_base.dart
File lib/src/hash_base.dart (right):

https://codereview.chromium.org/1349293002/diff/1/lib/src/hash_base.dart#newc...
lib/src/hash_base.dart:128: if (lengthInBits >= math.pow(2, 64)) {
Make the right side into a named constant?

https://codereview.chromium.org/1349293002/diff/1/lib/src/hash_base.dart#newc...
lib/src/hash_base.dart:129: throw "Hash undefined for message bit lengths larger
than 64 bits";
How about making this into an UnsupportedError instead of just throwing a
String?

[rmacnak, 2015-09-17 20:10:57]

https://codereview.chromium.org/1349293002/diff/1/lib/src/hash_base.dart
File lib/src/hash_base.dart (right):

https://codereview.chromium.org/1349293002/diff/1/lib/src/hash_base.dart#newc...
lib/src/hash_base.dart:128: if (lengthInBits >= math.pow(2, 64)) {
On 2015/09/17 19:48:11, Ivan Posva wrote:
> Make the right side into a named constant?

Done.

https://codereview.chromium.org/1349293002/diff/1/lib/src/hash_base.dart#newc...
lib/src/hash_base.dart:129: throw "Hash undefined for message bit lengths larger
than 64 bits";
On 2015/09/17 19:48:11, Ivan Posva wrote:
> How about making this into an UnsupportedError instead of just throwing a
> String?

Done.

[rmacnak, 2015-09-17 20:12:13]

Committed patchset #2 (id:20001) manually as
113e82096fc0cc5a3c190607cfe88184a36d0ffb (presubmit successful).

[nweiz, 2015-09-17 20:29:06]

DBC

Please add a test for this.

[sethladd, 2015-09-17 20:33:01]

On it.