Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(960)

Issue 1349263002: Wrap the http server start-up in an exception handler (issue 24363) (Closed)

Created:
5 years, 3 months ago by Brian Wilkerson
Modified:
5 years, 3 months ago
Reviewers:
devoncarew, kevmoo
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M pkg/analysis_server/lib/src/server/http_server.dart View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Brian Wilkerson
5 years, 3 months ago (2015-09-17 16:54:15 UTC) #2
devoncarew
lgtm Thanks!
5 years, 3 months ago (2015-09-17 17:06:37 UTC) #3
Brian Wilkerson
Committed patchset #1 (id:1) manually as 1a6daab9d1907318cf41905e6e62c44818958f33 (presubmit successful).
5 years, 3 months ago (2015-09-17 17:15:42 UTC) #4
kevmoo
DBQ: is silent failure a good idea? Perhaps a printout or something? Just curious...
5 years, 3 months ago (2015-09-17 22:19:42 UTC) #6
Brian Wilkerson
5 years, 3 months ago (2015-09-17 22:53:39 UTC) #7
Message was sent while issue was closed.
> is silent failure a good idea? Perhaps a printout or something?

It isn't a great idea. However, server runs headless (that is, the client starts
the process) and uses stdin and stdout to communicate with the client. If we
write to stdout it will break some clients. If we write to stderr it will
probably be ignored by clients. We could send a non-fatal "server failure"
notification, but as far as I know existing clients would just ignore it.

So, I'm not sure how to get any output to anyone that needs to know. Suggestions
welcome.

Powered by Google App Engine
This is Rietveld 408576698