Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1349223002: Fix for dynamic instance field reference highlighting. (Closed)

Created:
5 years, 3 months ago by scheglov
Modified:
5 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for dynamic instance field reference highlighting. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/a01281370b5277b151764feb361b610c8030d76d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M pkg/analysis_server/lib/src/computer/computer_highlights2.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_highlights_test2.dart View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 3 months ago (2015-09-17 15:24:07 UTC) #1
Brian Wilkerson
LGTM
5 years, 3 months ago (2015-09-17 16:07:47 UTC) #2
scheglov
5 years, 3 months ago (2015-09-17 16:25:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a01281370b5277b151764feb361b610c8030d76d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698