Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1348983002: Update documentation comments. (Closed)

Created:
5 years, 3 months ago by nweiz
Modified:
5 years, 3 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org, sethladd
Base URL:
git@github.com:dart-lang/crypto.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+289 lines, -203 lines) Patch
M lib/crypto.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M lib/src/base64.dart View 8 chunks +111 lines, -61 lines 0 comments Download
M lib/src/crypto_utils.dart View 2 chunks +23 lines, -32 lines 0 comments Download
M lib/src/hash.dart View 1 1 chunk +17 lines, -29 lines 0 comments Download
M lib/src/hash_base.dart View 9 chunks +49 lines, -14 lines 0 comments Download
M lib/src/hmac.dart View 2 chunks +40 lines, -30 lines 0 comments Download
M lib/src/md5.dart View 4 chunks +13 lines, -9 lines 0 comments Download
M lib/src/sha1.dart View 2 chunks +11 lines, -7 lines 0 comments Download
M lib/src/sha256.dart View 4 chunks +15 lines, -10 lines 0 comments Download
M lib/src/utils.dart View 1 chunk +10 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
nweiz
5 years, 3 months ago (2015-09-16 23:06:43 UTC) #2
Bob Nystrom
Really nice. LGTM! https://codereview.chromium.org/1348983002/diff/1/lib/src/hash.dart File lib/src/hash.dart (right): https://codereview.chromium.org/1348983002/diff/1/lib/src/hash.dart#newcode12 lib/src/hash.dart:12: /// If multiple instances of a ...
5 years, 3 months ago (2015-09-17 17:11:57 UTC) #3
nweiz
Code review changes
5 years, 3 months ago (2015-09-17 20:06:10 UTC) #4
nweiz
https://codereview.chromium.org/1348983002/diff/1/lib/src/hash.dart File lib/src/hash.dart (right): https://codereview.chromium.org/1348983002/diff/1/lib/src/hash.dart#newcode12 lib/src/hash.dart:12: /// If multiple instances of a given Hash is ...
5 years, 3 months ago (2015-09-17 20:06:41 UTC) #5
nweiz
5 years, 3 months ago (2015-09-17 20:22:51 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
c34372e05ecfaffcda0095caf0c1c7aeff38a112 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698