test large inputs for sha1 and sha256, also remove unused import

Test large inputs for sha1 and sha256, also remove unused import.

BUG=
R=rmacnak@google.com

Committed: https://github.com/dart-lang/crypto/commit/85e581ea9a3b9fbb84711f7ce0bad21c2c3c2328

[sethladd, 2015-09-17 21:15:29]

sethladd@google.com changed reviewers:
+ rmacnak@google.com

[rmacnak, 2015-09-17 21:21:31]

lgtm w/c

https://codereview.chromium.org/1348823004/diff/1/test/sha1_test.dart
File test/sha1_test.dart (right):

https://codereview.chromium.org/1348823004/diff/1/test/sha1_test.dart#newcode25
test/sha1_test.dart:25: test('input length greater than 32 bits', () {
input bit length greater than 32 bits

https://codereview.chromium.org/1348823004/diff/1/test/sha256_test.dart
File test/sha256_test.dart (right):

https://codereview.chromium.org/1348823004/diff/1/test/sha256_test.dart#newco...
test/sha256_test.dart:23: test('input length greater than 32 bits', () {
"

https://codereview.chromium.org/1348823004/diff/1/test/very_long_input.dart
File test/very_long_input.dart (right):

https://codereview.chromium.org/1348823004/diff/1/test/very_long_input.dart#n...
test/very_long_input.dart:6: veryLongInput(digester, int size, String verify) {
size -> byteLength

[sethladd, 2015-09-17 21:30:52]

https://codereview.chromium.org/1348823004/diff/1/test/sha1_test.dart
File test/sha1_test.dart (right):

https://codereview.chromium.org/1348823004/diff/1/test/sha1_test.dart#newcode25
test/sha1_test.dart:25: test('input length greater than 32 bits', () {
On 2015/09/17 21:21:31, rmacnak wrote:
> input bit length greater than 32 bits

Done.

https://codereview.chromium.org/1348823004/diff/1/test/sha256_test.dart
File test/sha256_test.dart (right):

https://codereview.chromium.org/1348823004/diff/1/test/sha256_test.dart#newco...
test/sha256_test.dart:23: test('input length greater than 32 bits', () {
On 2015/09/17 21:21:31, rmacnak wrote:
> "

Done.

https://codereview.chromium.org/1348823004/diff/1/test/very_long_input.dart
File test/very_long_input.dart (right):

https://codereview.chromium.org/1348823004/diff/1/test/very_long_input.dart#n...
test/very_long_input.dart:6: veryLongInput(digester, int size, String verify) {
On 2015/09/17 21:21:31, rmacnak wrote:
> size -> byteLength

Done.

[sethladd, 2015-09-17 21:32:22]

Committed patchset #2 (id:20001) manually as
85e581ea9a3b9fbb84711f7ce0bad21c2c3c2328 (presubmit successful).

[nweiz, 2015-09-21 21:34:21]

nweiz@google.com changed reviewers:
+ nweiz@google.com

[nweiz, 2015-09-21 21:34:21]

DBC

As far as I can tell, these tests will take on the order of three hours to
complete on a (relatively powerful) machine like mine. I don't think this is
something we should include in the normal test cycle for this package.

[sethladd, 2015-09-22 07:37:09]

I'm not familiar with how to write tests for our infrastructure that might take
a long time. Definitely open to ideas.

(how did you calculate three hours for these tests? curious...)

[nweiz, 2015-09-22 21:21:32]

On 2015/09/22 07:37:09, sethladd wrote:
> I'm not familiar with how to write tests for our infrastructure that might
take
> a long time. Definitely open to ideas.

In general, we just don't write tests that take this long.

> (how did you calculate three hours for these tests? curious...)

I added some instrumentation to print out how many iterations were being done
per second (a little over 100000) and did the math.