Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(738)

Issue 134873005: Get rid of SafeHttpServer. (Closed)

Created:
6 years, 11 months ago by nweiz
Modified:
6 years, 11 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Get rid of SafeHttpServer. The behavior issues with HttpServer that led to this being created seem to be solved now. R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=31761

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -492 lines) Patch
D pkg/http/test/safe_http_server.dart View 1 chunk +0 lines, -162 lines 0 comments Download
M pkg/http/test/utils.dart View 2 chunks +1 line, -3 lines 0 comments Download
M pkg/scheduled_test/lib/scheduled_server.dart View 2 chunks +1 line, -2 lines 0 comments Download
D pkg/scheduled_test/lib/src/scheduled_server/safe_http_server.dart View 1 chunk +0 lines, -151 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/oauth2.dart View 2 chunks +1 line, -2 lines 0 comments Download
D sdk/lib/_internal/pub/lib/src/safe_http_server.dart View 1 chunk +0 lines, -170 lines 0 comments Download
M sdk/lib/_internal/pub/test/test_pub.dart View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
6 years, 11 months ago (2014-01-13 21:16:45 UTC) #1
Bob Nystrom
lgtm
6 years, 11 months ago (2014-01-13 22:19:57 UTC) #2
nweiz
6 years, 11 months ago (2014-01-13 22:36:58 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r31761 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698