Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Issue 1348383002: Fix compiler stats (Closed)

Created:
5 years, 3 months ago by hausner
Modified:
5 years, 3 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix compiler stats Don’t print stats for VM and service isolates Guard against division by zero in all cases BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/2ee5a1289d0f1ad5397612b5c6840e9f1c4ddda8

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -17 lines) Patch
M runtime/vm/benchmark_test.cc View 4 chunks +0 lines, -4 lines 0 comments Download
M runtime/vm/compiler_stats.cc View 4 chunks +18 lines, -12 lines 0 comments Download
M runtime/vm/isolate.cc View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
hausner
5 years, 3 months ago (2015-09-16 20:57:52 UTC) #2
rmacnak
lgtm
5 years, 3 months ago (2015-09-16 21:03:30 UTC) #3
hausner
5 years, 3 months ago (2015-09-16 21:10:52 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
2ee5a1289d0f1ad5397612b5c6840e9f1c4ddda8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698