Issue 13483009: Fix http://dartbug.com/9137 :

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13483009: Fix http://dartbug.com/9137 : (Closed)

Created:
7 years, 8 months ago by Ivan Posva

Modified:
7 years, 8 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix http://dartbug.com/9137 : - Use non-normalized name when complaining about unrecognized flags. Committed: https://code.google.com/p/dart/source/detail?r=21811

Patch Set 1 #

Total comments: 2

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -4 lines)			Patch
	M	runtime/vm/flags.cc	View		2 chunks	+7 lines, -4 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm https://codereview.chromium.org/13483009/diff/1/runtime/vm/flags.cc File runtime/vm/flags.cc (right): https://codereview.chromium.org/13483009/diff/1/runtime/vm/flags.cc#newcode108 runtime/vm/flags.cc:108: return default_value; nobody seems to use the return ...

7 years, 8 months ago (2013-04-05 07:14:28 UTC) #2

Ivan Posva

https://codereview.chromium.org/13483009/diff/1/runtime/vm/flags.cc File runtime/vm/flags.cc (right): https://codereview.chromium.org/13483009/diff/1/runtime/vm/flags.cc#newcode108 runtime/vm/flags.cc:108: return default_value; On 2013/04/05 07:14:28, siva wrote: > nobody ...

7 years, 8 months ago (2013-04-22 12:59:27 UTC) #3

Ivan Posva

7 years, 8 months ago (2013-04-22 12:59:48 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r21811 (presubmit successful).

Expand Messages | Collapse Messages