Issue 1348233002: dart2js cps: Set receiver-nullability in analysis pass.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1348233002: dart2js cps: Set receiver-nullability in analysis pass. (Closed)

Created:
5 years, 3 months ago by asgerf

Modified:
5 years, 3 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

dart2js cps: Set receiver-nullability in analysis pass. Setting receiverIsNotNull, objectIsNotNull in the analysis pass simplifies the transformation pass since predicates like 'isSafeForElimination' depend on them. This would prevent constant folding of array lengths since GetLength was not marked as safe for elimination at the time it was considered for constant folding. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/8c6b990305c8d0d3111ff870deaa2bc2c0adef11

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -15 lines)			Patch
	M	pkg/compiler/lib/src/cps_ir/type_propagation.dart	View		8 chunks	+6 lines, -15 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Kevin Millikin (Google)

LGTM. I'm always surprised that the analysis implementation is after the transformation implementation in this ...

5 years, 3 months ago (2015-09-17 10:25:15 UTC) #3

asgerf

5 years, 3 months ago (2015-09-21 10:43:31 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8c6b990305c8d0d3111ff870deaa2bc2c0adef11 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages