Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1348063002: Make the universe parts into small libraries. (Closed)

Created:
5 years, 3 months ago by Johnni Winther
Modified:
5 years, 3 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+304 lines, -144 lines) Patch
M pkg/compiler/lib/src/common.dart View 2 chunks +8 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/common/codegen.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/common/names.dart View 2 chunks +7 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/compile_time_constants.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/constants/constant_constructors.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/constants/constructors.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/constants/evaluation.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/constants/expressions.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_fragment.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 4 chunks +7 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_mask_system.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 3 chunks +13 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/dart_backend.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/concrete_types_inferrer.dart View 4 chunks +8 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/inferrer_visitor.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart View 1 chunk +5 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart View 1 chunk +6 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/codegen.dart View 4 chunks +5 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/glue.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/unsugar.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/js_backend.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/js_emitter.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/parameter_stub_generator.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/native/native.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/class_hierarchy.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/resolution/constructors.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/operators.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/registry.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution_result.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/send_resolver.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/send_structure.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/tree_elements.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/serialization/constant_serialization.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/serialization/element_serialization.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/invoke_dynamic_specializers.dart View 3 chunks +7 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/ssa/ssa.dart View 1 chunk +8 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/types/types.dart View 1 chunk +11 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/universe/call_structure.dart View 2 chunks +26 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/universe/function_set.dart View 1 chunk +17 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/universe/selector.dart View 5 chunks +32 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/universe/side_effects.dart View 1 chunk +25 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/universe/universe.dart View 1 chunk +5 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/world.dart View 1 chunk +6 lines, -4 lines 0 comments Download
M pkg/dart2js_incremental/lib/library_updater.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/analyze_dart2js_helpers_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/backend_dart/sexpr_unstringifier.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/cpa_inference_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/gvn_dynamic_field_get_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/js_spec_string_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/patch_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/related_types.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
Main changes in universe/*
5 years, 3 months ago (2015-09-16 10:48:26 UTC) #2
karlklose
LGTM.
5 years, 3 months ago (2015-09-16 11:29:34 UTC) #3
Johnni Winther
5 years, 3 months ago (2015-09-16 13:09:26 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
7ef93ef03a0a4bb969afbb2bca6f932ad5b1edc7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698