Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 1347693004: getIsolate rpc now returns collected sentinel for expired isolate. (Closed)

Created:
5 years, 3 months ago by turnidge
Modified:
5 years, 3 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

getIsolate rpc now returns collected sentinel for expired isolate. Closes #24353 R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/b956f981e5de9d4e1ef6e12f53496f5b6375b3e2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -18 lines) Patch
M runtime/observatory/tests/service/get_isolate_rpc_test.dart View 1 chunk +11 lines, -0 lines 0 comments Download
M runtime/vm/service/running_isolates.dart View 1 chunk +8 lines, -2 lines 0 comments Download
M runtime/vm/service/service.md View 2 chunks +7 lines, -4 lines 0 comments Download
M runtime/vm/service/vmservice.dart View 5 chunks +13 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
turnidge
5 years, 3 months ago (2015-09-15 19:28:23 UTC) #2
Cutch
lgtm
5 years, 3 months ago (2015-09-15 19:37:54 UTC) #3
turnidge
5 years, 3 months ago (2015-09-16 17:10:21 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b956f981e5de9d4e1ef6e12f53496f5b6375b3e2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698