Fix error in processing dart-ext urls with a relative path.

Fix error in processing dart-ext urls with a relative path.

BUG=dartbug.com/16205
R=sgjesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=32031

Committed: https://code.google.com/p/dart/source/detail?r=32046

[Bill Hesse, 2014-01-27 20:16:47]

We will want to push this to stable asap.

[Søren Gjesse, 2014-01-27 20:57:35]

On 2014/01/27 20:16:47, Bill Hesse wrote:
> We will want to push this to stable asap.

lgtm, with comments.

Can we somehow add a test for this?

[Søren Gjesse, 2014-01-27 20:57:51]

Here are the comments

https://codereview.chromium.org/134753005/diff/1/runtime/bin/builtin.dart
File runtime/bin/builtin.dart (right):

https://codereview.chromium.org/134753005/diff/1/runtime/bin/builtin.dart#new...
runtime/bin/builtin.dart:246: case 'dart-ext':
This should just be

  new Uri.file(uri.path)

that should take care of the relative/absolute path.

Also shouldn't we check that the host is empty? Don't think we want to load
extensions from a file server.

[Bill Hesse, 2014-01-27 21:57:37]

On 2014/01/27 20:57:51, Søren Gjesse wrote:
> Here are the comments
> 
> https://codereview.chromium.org/134753005/diff/1/runtime/bin/builtin.dart
> File runtime/bin/builtin.dart (right):
> 
>
https://codereview.chromium.org/134753005/diff/1/runtime/bin/builtin.dart#new...
> runtime/bin/builtin.dart:246: case 'dart-ext':
> This should just be
> 
>   new Uri.file(uri.path)
> 
> that should take care of the relative/absolute path.
> 
> Also shouldn't we check that the host is empty? Don't think we want to load
> extensions from a file server.

If we don't want to load extensions from a file server, then this case is fine. 
I thought that perhaps we did - someone could be running all their stuff from a
file server.

We should revisit this decision later, and decide what to do with servers.


I think the bug did not show on the buildbots because they resolved the
extension path against the script path, which was absolute, before calling this
code.  So the path was absolute by the time it got here.  We might be able to
reproduce it by running the sample extension tests with a relative path to the
script.

[Bill Hesse, 2014-01-27 21:58:27]

Committed patchset #4 manually as r32031 (presubmit successful).

[Bill Hesse, 2014-01-28 00:32:33]

Reverting this change to patchset 1.  The change in patchset 3 was wrong - the
input is not a file path, it is the path component of a file URI, so it breaks
new Uri.file.  I t needs to use new Uri(path: uri.path), with scheme of either
"file" or "".  The path can be of the form /c:/foo/bar.

[Bill Hesse, 2014-01-28 00:33:23]

Committed patchset #6 manually as r32046 (presubmit successful).