Issue 1347423003: dart2js: Make sure that super classes have their inheritance chain set up correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1347423003: dart2js: Make sure that super classes have their inheritance chain set up correctly. (Closed)

Created:
5 years, 3 months ago by floitsch

Modified:
5 years, 3 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

dart2js: Make sure that super classes have their inheritance chain set up correctly. This bug was only happening for the --fast-startup. For most browsers we simply change the '__proto__' and the order wouldn't be important. However, for the other browsers we have to do it in order. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/f36b8aa4e4dd0a44015a829ca715f7c09b736861

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+147 lines, -6 lines)			Patch
M	pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart	View	1 chunk	+19 lines, -6 lines	0 comments	Download
A	tests/language/inheritance_chain_lib.dart	View	1 chunk	+25 lines, -0 lines	0 comments	Download
A	tests/language/inheritance_chain_test.dart	View	1 chunk	+103 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

floitsch

The test is currently not run, since we don't have buildbots running the startup flag. ...

5 years, 3 months ago (2015-09-22 18:25:49 UTC) #2

floitsch

5 years, 3 months ago (2015-09-23 09:48:22 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f36b8aa4e4dd0a44015a829ca715f7c09b736861 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages