Issue 13473010: Adds native/leaf runtime call stub and redirection on MIPS.

Issue 13473010: Adds native/leaf runtime call stub and redirection on MIPS. (Closed)

Created:
7 years, 8 months ago by zra

Modified:
7 years, 8 months ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Adds native/leaf runtime call stub and redirection on MIPS. Committed: https://code.google.com/p/dart/source/detail?r=20813

Patch Set 4 : #

Total comments: 2

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+188 lines, -18 lines)			Patch
M	runtime/tests/vm/vm.status	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	runtime/vm/assembler_mips.h	View	1 2 3	2 chunks	+10 lines, -0 lines	2 comments	Download
M	runtime/vm/flow_graph_compiler_mips.cc	View	1 2	2 chunks	+4 lines, -1 line	0 comments	Download
M	runtime/vm/instructions_mips.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/instructions_mips.cc	View	1 2	1 chunk	+23 lines, -5 lines	0 comments	Download
M	runtime/vm/instructions_mips_test.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View		1 chunk	+37 lines, -3 lines	0 comments	Download
M	runtime/vm/stub_code_mips.cc	View	1 2	1 chunk	+84 lines, -1 line	0 comments	Download
M	runtime/vm/stub_code_mips_test.cc	View		2 chunks	+26 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://codereview.chromium.org/13473010/diff/4002/runtime/vm/assembler_mips.h File runtime/vm/assembler_mips.h (right): https://codereview.chromium.org/13473010/diff/4002/runtime/vm/assembler_mips.h#newcode524 runtime/vm/assembler_mips.h:524: } Ah, it is back :-) But you ...

7 years, 8 months ago (2013-04-02 20:16:03 UTC) #2

zra

Thanks! https://codereview.chromium.org/13473010/diff/4002/runtime/vm/assembler_mips.h File runtime/vm/assembler_mips.h (right): https://codereview.chromium.org/13473010/diff/4002/runtime/vm/assembler_mips.h#newcode524 runtime/vm/assembler_mips.h:524: } On 2013/04/02 20:16:03, regis wrote: > Ah, ...

7 years, 8 months ago (2013-04-02 20:24:40 UTC) #3

zra

Committed patchset #4 manually as r20813 (presubmit successful).

7 years, 8 months ago (2013-04-02 20:25:27 UTC) #4

regis

7 years, 8 months ago (2013-04-02 20:40:50 UTC) #5

Message was sent while issue was closed.

Maybe for a later cl.

https://codereview.chromium.org/13473010/diff/12/runtime/vm/assembler_mips.h
File runtime/vm/assembler_mips.h (right):

https://codereview.chromium.org/13473010/diff/12/runtime/vm/assembler_mips.h#...
runtime/vm/assembler_mips.h:524: delay_slot()->nop();
This works, but there is already a nop in the delay slot. This would be
clearer/simpler:
delay_slot_available_ = false;  // CodePatcher expects a nop.

https://codereview.chromium.org/13473010/diff/12/runtime/vm/assembler_mips.h#...
runtime/vm/assembler_mips.h:537: delay_slot()->nop();
ditto

Expand Messages | Collapse Messages