Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 1347223002: Produce LINE_INFO for HTML files. (Closed)

Created:
5 years, 3 months ago by scheglov
Modified:
5 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -7 lines) Patch
M pkg/analyzer/lib/src/generated/source.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/task/html.dart View 5 chunks +22 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/task/html_test.dart View 3 chunks +27 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 3 months ago (2015-09-16 19:47:12 UTC) #1
Brian Wilkerson
LGTM
5 years, 3 months ago (2015-09-16 19:52:29 UTC) #2
scheglov
5 years, 3 months ago (2015-09-16 20:28:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
aab6cf0b359706d56e9bdb1c2ef3abc490559e24 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698