Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1347203005: VM: Intrinsify some common SIMD methods to speed up precompiled SIMD code. (Closed)

Created:
5 years, 3 months ago by Florian Schneider
Modified:
5 years, 3 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Intrinsify some common SIMD methods to speed up precompiled SIMD code. This speeds up precompiled code using SIMD (around 2x on Tracer). Also fix printing of recognized methods which was off-by-one. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/60b4e00770a364c8ce70e1780b061d6d112de59f

Patch Set 1 #

Total comments: 4

Patch Set 2 : added helper to create unboxing instructions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -13 lines) Patch
M runtime/vm/intrinsifier.cc View 1 4 chunks +130 lines, -8 lines 0 comments Download
M runtime/vm/method_recognizer.h View 2 chunks +7 lines, -4 lines 0 comments Download
M runtime/vm/method_recognizer.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Florian Schneider
5 years, 3 months ago (2015-09-22 15:22:03 UTC) #2
Cutch
LGTM with a suggestion https://codereview.chromium.org/1347203005/diff/1/runtime/vm/intrinsifier.cc File runtime/vm/intrinsifier.cc (right): https://codereview.chromium.org/1347203005/diff/1/runtime/vm/intrinsifier.cc#newcode529 runtime/vm/intrinsifier.cc:529: new Value(left), What about creating ...
5 years, 3 months ago (2015-09-22 15:48:05 UTC) #3
Florian Schneider
https://codereview.chromium.org/1347203005/diff/1/runtime/vm/intrinsifier.cc File runtime/vm/intrinsifier.cc (right): https://codereview.chromium.org/1347203005/diff/1/runtime/vm/intrinsifier.cc#newcode529 runtime/vm/intrinsifier.cc:529: new Value(left), On 2015/09/22 15:48:05, Cutch wrote: > What ...
5 years, 3 months ago (2015-09-22 16:13:38 UTC) #4
Florian Schneider
5 years, 3 months ago (2015-09-22 16:28:07 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
60b4e00770a364c8ce70e1780b061d6d112de59f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698