Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 13472016: Split apart several asynchronous tests to reduce timeouts. (Closed)

Created:
7 years, 8 months ago by nweiz
Modified:
7 years, 8 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Split apart several asynchronous tests to reduce timeouts. Committed: https://code.google.com/p/dart/source/detail?r=20827

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3084 lines, -2738 lines) Patch
M pkg/pkg.status View 1 chunk +0 lines, -4 lines 0 comments Download
A pkg/scheduled_test/test/descriptor/async_test.dart View 1 1 chunk +143 lines, -0 lines 0 comments Download
A pkg/scheduled_test/test/descriptor/directory_test.dart View 1 1 chunk +414 lines, -0 lines 0 comments Download
A pkg/scheduled_test/test/descriptor/file_test.dart View 1 1 chunk +183 lines, -0 lines 0 comments Download
A pkg/scheduled_test/test/descriptor/nothing_test.dart View 1 1 chunk +105 lines, -0 lines 0 comments Download
A pkg/scheduled_test/test/descriptor/pattern_test.dart View 1 1 chunk +169 lines, -0 lines 0 comments Download
A pkg/scheduled_test/test/descriptor/utils.dart View 1 chunk +43 lines, -0 lines 0 comments Download
D pkg/scheduled_test/test/descriptor_test.dart View 1 chunk +0 lines, -981 lines 0 comments Download
A pkg/scheduled_test/test/scheduled_future_matchers_test.dart View 1 1 chunk +85 lines, -0 lines 0 comments Download
M pkg/scheduled_test/test/scheduled_process_test.dart View 1 1 chunk +1 line, -7 lines 0 comments Download
M pkg/scheduled_test/test/scheduled_server_test.dart View 1 1 chunk +1 line, -5 lines 0 comments Download
A pkg/scheduled_test/test/scheduled_test/abort_test.dart View 1 1 chunk +94 lines, -0 lines 0 comments Download
A pkg/scheduled_test/test/scheduled_test/current_schedule_current_task_test.dart View 1 1 chunk +68 lines, -0 lines 0 comments Download
A pkg/scheduled_test/test/scheduled_test/current_schedule_errors_test.dart View 1 1 chunk +239 lines, -0 lines 0 comments Download
A pkg/scheduled_test/test/scheduled_test/current_schedule_state_test.dart View 1 1 chunk +44 lines, -0 lines 0 comments Download
A pkg/scheduled_test/test/scheduled_test/nested_task_test.dart View 1 1 chunk +137 lines, -0 lines 0 comments Download
A pkg/scheduled_test/test/scheduled_test/on_complete_test.dart View 1 1 chunk +162 lines, -0 lines 0 comments Download
A pkg/scheduled_test/test/scheduled_test/on_exception_test.dart View 1 1 chunk +78 lines, -0 lines 0 comments Download
A pkg/scheduled_test/test/scheduled_test/out_of_band_task_test.dart View 1 1 chunk +49 lines, -0 lines 0 comments Download
A pkg/scheduled_test/test/scheduled_test/set_up_test.dart View 1 1 chunk +143 lines, -0 lines 0 comments Download
A pkg/scheduled_test/test/scheduled_test/signal_error_test.dart View 1 1 chunk +48 lines, -0 lines 0 comments Download
A pkg/scheduled_test/test/scheduled_test/simple_test.dart View 1 1 chunk +123 lines, -0 lines 0 comments Download
A pkg/scheduled_test/test/scheduled_test/task_return_value_test.dart View 1 1 chunk +82 lines, -0 lines 0 comments Download
A pkg/scheduled_test/test/scheduled_test/timeout_test.dart View 1 1 chunk +202 lines, -0 lines 0 comments Download
A pkg/scheduled_test/test/scheduled_test/wrap_async_test.dart View 1 1 chunk +37 lines, -0 lines 0 comments Download
A pkg/scheduled_test/test/scheduled_test/wrap_future_test.dart View 1 1 chunk +84 lines, -0 lines 0 comments Download
D pkg/scheduled_test/test/scheduled_test_test.dart View 1 chunk +0 lines, -1450 lines 0 comments Download
M pkg/scheduled_test/test/utils.dart View 1 2 chunks +14 lines, -0 lines 0 comments Download
A utils/tests/pub/oauth2/utils.dart View 1 chunk +62 lines, -0 lines 0 comments Download
A utils/tests/pub/oauth2/with_a_malformed_credentials_authenticates_again_test.dart View 1 chunk +44 lines, -0 lines 0 comments Download
A + utils/tests/pub/oauth2/with_a_pre_existing_credentials_does_not_authenticate_test.dart View 1 chunk +11 lines, -10 lines 0 comments Download
A utils/tests/pub/oauth2/with_a_server_rejected_refresh_token_authenticates_again_test.dart View 1 chunk +54 lines, -0 lines 0 comments Download
A utils/tests/pub/oauth2/with_an_expired_credentials_refreshes_and_saves_test.dart View 1 chunk +59 lines, -0 lines 0 comments Download
A utils/tests/pub/oauth2/with_an_expired_credentials_without_a_refresh_token_authenticates_again_test.dart View 1 chunk +47 lines, -0 lines 0 comments Download
A utils/tests/pub/oauth2/with_no_credentials_authenticates_and_saves_credentials_test.dart View 1 chunk +39 lines, -0 lines 0 comments Download
A + utils/tests/pub/oauth2/with_server_rejected_credentials_authenticates_again_test.dart View 1 chunk +20 lines, -17 lines 0 comments Download
D utils/tests/pub/oauth2_test.dart View 1 chunk +0 lines, -264 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nweiz
7 years, 8 months ago (2013-04-02 21:58:11 UTC) #1
Bob Nystrom
Couple of nits then LGTM. https://codereview.chromium.org/13472016/diff/1/pkg/scheduled_test/test/descriptor/async_test.dart File pkg/scheduled_test/test/descriptor/async_test.dart (right): https://codereview.chromium.org/13472016/diff/1/pkg/scheduled_test/test/descriptor/async_test.dart#newcode22 pkg/scheduled_test/test/descriptor/async_test.dart:22: }); How about moving ...
7 years, 8 months ago (2013-04-02 22:03:17 UTC) #2
nweiz
https://codereview.chromium.org/13472016/diff/1/pkg/scheduled_test/test/descriptor/async_test.dart File pkg/scheduled_test/test/descriptor/async_test.dart (right): https://codereview.chromium.org/13472016/diff/1/pkg/scheduled_test/test/descriptor/async_test.dart#newcode22 pkg/scheduled_test/test/descriptor/async_test.dart:22: }); On 2013/04/02 22:03:17, Bob Nystrom wrote: > How ...
7 years, 8 months ago (2013-04-02 22:38:44 UTC) #3
nweiz
7 years, 8 months ago (2013-04-02 22:39:59 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r20827 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698