Issue 13472005: Started passing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13472005: Started passing. (Closed)

Created:
7 years, 8 months ago by kasperl

Modified:
7 years, 8 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Started passing. R=floitsch@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=20774

Patch Set 1 #

Total comments: 1

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	tests/isolate/isolate.status	View		1 chunk	+0 lines, -1 line	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kasperl

Committed patchset #1 manually as r20774 (presubmit successful).

7 years, 8 months ago (2013-04-02 12:34:43 UTC) #2

floitsch

7 years, 8 months ago (2013-04-02 13:20:09 UTC) #4

Message was sent while issue was closed.

LGTM.

https://codereview.chromium.org/13472005/diff/1/tests/isolate/isolate.status
File tests/isolate/isolate.status (left):

https://codereview.chromium.org/13472005/diff/1/tests/isolate/isolate.status#...
tests/isolate/isolate.status:7: nested_spawn_stream2_test: Fail, Crash # Bug in
v8, http://dartbug.com/9407
Maybe mark it as flaky?
The other tests still fail, so I would assume that the v8 bug is still present.
Unless nested_spawn_stream2_test was misdiagnosed it has a high chance of
failing again.

Expand Messages | Collapse Messages