Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 13470006: Only lookup and delete the monitor wait data if it was allocated. (Closed)

Created:
7 years, 8 months ago by Søren Gjesse
Modified:
7 years, 8 months ago
Reviewers:
Mads Ager (google)
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Only lookup and delete the monitor wait data if it was allocated. R=ager@google.com BUG=https://code.google.com/p/dart/issues/detail?id=9403 Committed: https://code.google.com/p/dart/source/detail?r=20772

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M runtime/platform/thread_win.cc View 1 chunk +9 lines, -6 lines 0 comments Download
M tests/standalone/standalone.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Gjesse
Not 100% sure that this is what is causing the assertion to be hit. From ...
7 years, 8 months ago (2013-04-02 12:26:31 UTC) #1
Mads Ager (google)
LGTM, thanks!
7 years, 8 months ago (2013-04-02 12:28:10 UTC) #2
Søren Gjesse
7 years, 8 months ago (2013-04-02 12:29:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20772 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698