Issue 134693004: Mark watcher/directory_watcher/polling_test as timing out.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 134693004: Mark watcher/directory_watcher/polling_test as timing out. (Closed)

Created:
6 years, 11 months ago by nweiz

Modified:
6 years, 11 months ago

Reviewers:
Bob Nystrom, Ivan Posva

CC:
reviews_dartlang.org, ricow1, kustermann

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Mark watcher/directory_watcher/polling_test as timing out. R=rnystrom@google.com BUG=16023 Committed: https://code.google.com/p/dart/source/detail?r=31712

Patch Set 1 #

Total comments: 1

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	pkg/pkg.status	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

nweiz

Committed patchset #1 manually as r31712 (presubmit successful).

6 years, 11 months ago (2014-01-10 21:57:07 UTC) #3

Ivan Posva

6 years, 11 months ago (2014-01-10 22:18:36 UTC) #4

Message was sent while issue was closed.

Rico, Martin,

FYI about cycle time impact as it degrades the machine by 25% for one minute.

-Ivan

https://codereview.chromium.org/134693004/diff/1/pkg/pkg.status
File pkg/pkg.status (right):

https://codereview.chromium.org/134693004/diff/1/pkg/pkg.status#newcode20
pkg/pkg.status:20: watcher/test/directory_watcher/polling_test: Timeout # Issue
16023
This means that this test will burn 1 available core for the whole time, making
cycle times unnecessarily longer.

Expand Messages | Collapse Messages