Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 1346923007: allow dart:* libs to implement otherwise disallowed types (e.g. int) (Closed)

Created:
5 years, 3 months ago by Jennifer Messerly
Modified:
5 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

allow dart:* libs to implement otherwise disallowed types (e.g. int) all current and experimental Dart implementations (dart2js, vm, fletch, ddc) get an error in their SDK from this. The CL fixes it by allowing dart:* libraries to implement the disallowed types, like int/double/String/bool. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/d7cd11f86a02f55269fc8d9843e7758ebeeb81c8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M pkg/analyzer/lib/src/generated/error_verifier.dart View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jennifer Messerly
5 years, 3 months ago (2015-09-18 00:51:52 UTC) #2
Brian Wilkerson
LGTM
5 years, 3 months ago (2015-09-18 13:46:57 UTC) #3
Jennifer Messerly
5 years, 3 months ago (2015-09-18 14:11:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d7cd11f86a02f55269fc8d9843e7758ebeeb81c8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698