Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Issue 13466011: Remove dart:io import from ssa/tracer.dart. (Closed)

Created:
7 years, 8 months ago by ahe
Modified:
7 years, 8 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Merged and added import of EventSink. #

Patch Set 3 : Reopened #

Patch Set 4 : Merged with trunk #

Patch Set 5 : Update status file and fix type error #

Patch Set 6 : Update co19 status #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M dart/sdk/lib/_internal/compiler/implementation/apiimpl.dart View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/lib/js_string.dart View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/ssa/tracer.dart View 1 3 chunks +6 lines, -8 lines 0 comments Download
M dart/tests/co19/co19-dart2js.status View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
M dart/tests/utils/utils.status View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
ahe
7 years, 8 months ago (2013-04-02 17:53:35 UTC) #1
Johnni Winther
lgtm
7 years, 8 months ago (2013-04-02 18:13:42 UTC) #2
ahe
Committed patchset #2 manually as r20917 (presubmit successful).
7 years, 8 months ago (2013-04-04 14:06:34 UTC) #3
ahe
Second try
7 years, 8 months ago (2013-04-05 11:36:05 UTC) #4
Johnni Winther
lgtm
7 years, 8 months ago (2013-04-05 11:40:04 UTC) #5
ahe
7 years, 8 months ago (2013-04-05 11:52:55 UTC) #6
Message was sent while issue was closed.
Committed patchset #6 manually as r20961 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698