Flipping the direction of WheelEvent.deltaX/Y to follow standards

Flipping the direction of WheelEvent.deltaX/Y to follow standards

We're trying to follow the W3C spec for WheelEvent, but the standard has the direction in the opposite direction from what we have it now.

BUG=6215
Committed: https://code.google.com/p/dart/source/detail?r=20879

[Emily Fortuna, 2013-04-02 23:59:08]

lgtm with comment addition

https://codereview.chromium.org/13465021/diff/5001/tools/dom/templates/html/i...
File tools/dom/templates/html/impl/impl_WheelEvent.darttemplate (right):

https://codereview.chromium.org/13465021/diff/5001/tools/dom/templates/html/i...
tools/dom/templates/html/impl/impl_WheelEvent.darttemplate:25: // If
polyfilling, then flip these to match W3C wheel spec.
Can you link to the w3c spec or (better) say which direction is positive
according to the spec here?

[Andrei Mouravski, 2013-04-03 00:10:31]

https://codereview.chromium.org/13465021/diff/5001/tools/dom/templates/html/i...
File tools/dom/templates/html/impl/impl_WheelEvent.darttemplate (right):

https://codereview.chromium.org/13465021/diff/5001/tools/dom/templates/html/i...
tools/dom/templates/html/impl/impl_WheelEvent.darttemplate:8: 
Could you add some minimal dartdoc documentation?

[blois, 2013-04-03 00:35:34]

https://codereview.chromium.org/13465021/diff/5001/tools/dom/templates/html/i...
File tools/dom/templates/html/impl/impl_WheelEvent.darttemplate (right):

https://codereview.chromium.org/13465021/diff/5001/tools/dom/templates/html/i...
tools/dom/templates/html/impl/impl_WheelEvent.darttemplate:8: 
On 2013/04/03 00:10:31, Andrei Mouravski wrote:
> Could you add some minimal dartdoc documentation? 

Added some comments to the deltaX/deltaY members.

https://codereview.chromium.org/13465021/diff/5001/tools/dom/templates/html/i...
tools/dom/templates/html/impl/impl_WheelEvent.darttemplate:25: // If
polyfilling, then flip these to match W3C wheel spec.
On 2013/04/02 23:59:09, Emily Fortuna wrote:
> Can you link to the w3c spec or (better) say which direction is positive
> according to the spec here?

Added link to the spec, but it doesn't actually specify which direction is
positive. Primary thing is that if we're flipping the values on the read-back,
then we should unflip them here so manually generated events are consistent.

IE10 and FF recently added support for the W3C events (though IE does not
publicize it properly, so we don't use it there). I was able to validate that
they are both consistent in their direction, so this adjusts the polyfills to be
consistent as well.

[Andrei Mouravski, 2013-04-03 15:22:00]

lgtm

Err... I thought that I'd sent this already.

https://codereview.chromium.org/13465021/diff/8002/tools/dom/templates/html/i...
File tools/dom/templates/html/impl/impl_WheelEvent.darttemplate (right):

https://codereview.chromium.org/13465021/diff/8002/tools/dom/templates/html/i...
tools/dom/templates/html/impl/impl_WheelEvent.darttemplate:92: * * [W3C
WheelEvent](http://dev.w3.org/2006/webapi/DOM-Level-3-Events/html/DOM3-Events.html#events-WheelEvent-deltaY)
Nit: we have been annotating these as [Foo](link.com) from the W3C.

[blois, 2013-04-03 17:52:20]

Committed patchset #3 manually as r20879 (presubmit successful).

[blois, 2013-04-03 18:00:49]

https://codereview.chromium.org/13465021/diff/8002/tools/dom/templates/html/i...
File tools/dom/templates/html/impl/impl_WheelEvent.darttemplate (right):

https://codereview.chromium.org/13465021/diff/8002/tools/dom/templates/html/i...
tools/dom/templates/html/impl/impl_WheelEvent.darttemplate:92: * * [W3C
WheelEvent](http://dev.w3.org/2006/webapi/DOM-Level-3-Events/html/DOM3-Events.html#events-WheelEvent-deltaY)
On 2013/04/03 15:22:00, Andrei Mouravski wrote:
> Nit: we have been annotating these as [Foo](link.com) from the W3C.

Done.