Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1346473002: Move megamorphic cache table into the Dart heap. (Closed)

Created:
5 years, 3 months ago by rmacnak
Modified:
5 years, 3 months ago
Reviewers:
srdjan, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : AllStatic #

Patch Set 3 : non-x64 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -102 lines) Patch
M runtime/vm/code_generator.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/dart.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm64.cc View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M runtime/vm/isolate.h View 1 2 chunks +0 lines, -5 lines 0 comments Download
M runtime/vm/isolate.cc View 1 2 chunks +1 line, -4 lines 0 comments Download
M runtime/vm/megamorphic_cache_table.h View 1 2 chunks +13 lines, -24 lines 0 comments Download
M runtime/vm/megamorphic_cache_table.cc View 1 2 chunks +38 lines, -46 lines 3 comments Download
M runtime/vm/object.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M runtime/vm/object_store.h View 2 chunks +16 lines, -1 line 0 comments Download
M runtime/vm/object_store.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
rmacnak
https://codereview.chromium.org/1346473002/diff/1/runtime/vm/megamorphic_cache_table.cc File runtime/vm/megamorphic_cache_table.cc (right): https://codereview.chromium.org/1346473002/diff/1/runtime/vm/megamorphic_cache_table.cc#newcode24 runtime/vm/megamorphic_cache_table.cc:24: table = GrowableObjectArray::New(); The heap isn't setup yet when ...
5 years, 3 months ago (2015-09-14 21:16:20 UTC) #2
rmacnak
AllStatic
5 years, 3 months ago (2015-09-14 21:54:07 UTC) #3
rmacnak
non-X64
5 years, 3 months ago (2015-09-14 22:36:49 UTC) #4
siva
lgtm
5 years, 3 months ago (2015-09-14 23:46:11 UTC) #5
rmacnak
Committed patchset #3 (id:40001) manually as 3068f1e092e10fe51e714b1f797bb457454e8c59 (presubmit successful).
5 years, 3 months ago (2015-09-15 00:12:00 UTC) #6
srdjan
5 years, 3 months ago (2015-09-23 17:27:44 UTC) #8
Message was sent while issue was closed. 
DBC

https://codereview.chromium.org/1346473002/diff/40001/runtime/vm/megamorphic_...
File runtime/vm/megamorphic_cache_table.cc (right):

https://codereview.chromium.org/1346473002/diff/40001/runtime/vm/megamorphic_...
runtime/vm/megamorphic_cache_table.cc:22: GrowableObjectArray& table =
GrowableObjectArray::Handle(
isolate,

https://codereview.chromium.org/1346473002/diff/40001/runtime/vm/megamorphic_...
runtime/vm/megamorphic_cache_table.cc:25: table = GrowableObjectArray::New();
Allocate in old space? it will move there anyway.

https://codereview.chromium.org/1346473002/diff/40001/runtime/vm/megamorphic_...
runtime/vm/megamorphic_cache_table.cc:39: table.Add(name);
Add in old space (if array allocated in old space).

Powered by Google App Engine
This is Rietveld 408576698