Issue 13464023: Fixed an issue with subprocess.call.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13464023: Fixed an issue with subprocess.call. (Closed)

Created:
7 years, 8 months ago by Andrei Mouravski

Modified:
7 years, 8 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Fixed an issue with subprocess.call. Also, the exit code was wrong. Committed: https://code.google.com/p/dart/source/detail?r=20874

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -4 lines)			Patch
	M	tools/dom/dom.py	View		2 chunks	+9 lines, -4 lines	0 comments	Download

Total messages: 4 (0 generated)

Emily Fortuna

lgtm. what was the issue? Yeah, I'd never written the code the way you had ...

7 years, 8 months ago (2013-04-03 16:30:00 UTC) #2

Andrei Mouravski

On 2013/04/03 16:30:00, Emily Fortuna wrote: > lgtm. what was the issue? > > Yeah, ...

7 years, 8 months ago (2013-04-03 16:31:45 UTC) #3

Andrei Mouravski

7 years, 8 months ago (2013-04-03 16:32:16 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r20874 (presubmit successful).