Issue 13464021: Fix issue 9608: When replacing call with assert assignable, transfer call's deopt_id to the new nod…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13464021: Fix issue 9608: When replacing call with assert assignable, transfer call's deopt_id to the new nod… (Closed)

Created:
7 years, 8 months ago by srdjan

Modified:
7 years, 8 months ago

Reviewers:
siva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix issue 9608: When replacing call with assert assignable, transfer call's deopt_id to the new node. Committed: https://code.google.com/p/dart/source/detail?r=20871

Patch Set 2 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -8 lines)			Patch
M	runtime/vm/flow_graph_optimizer.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	tests/language/language.status	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm https://codereview.chromium.org/13464021/diff/1/tests/language/language.status File tests/language/language.status (right): https://codereview.chromium.org/13464021/diff/1/tests/language/language.status#newcode324 tests/language/language.status:324: [ $runtime == vm && $checked && $mode ...

7 years, 8 months ago (2013-04-03 15:38:49 UTC) #2

srdjan

https://codereview.chromium.org/13464021/diff/1/tests/language/language.status File tests/language/language.status (right): https://codereview.chromium.org/13464021/diff/1/tests/language/language.status#newcode324 tests/language/language.status:324: [ $runtime == vm && $checked && $mode == ...

7 years, 8 months ago (2013-04-03 15:42:32 UTC) #3

srdjan

7 years, 8 months ago (2013-04-03 16:22:30 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r20871 (presubmit successful).

Expand Messages | Collapse Messages

Issue 13464021: Fix issue 9608: When replacing call with assert assignable, transfer call's deopt_id to the new nod… (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages