Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Issue 13463003: Revert "Workaround issue 8080:" (Closed)

Created:
7 years, 8 months ago by ahe
Modified:
7 years, 8 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Revert "Workaround issue 8080:" This reverts r20486. Committed: https://code.google.com/p/dart/source/detail?r=20778

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M dart/tools/testing/dart/test_suite.dart View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ahe
As I have explained in http://dartbug.com/8080, this workaround is incorrect. I plan to remove the ...
7 years, 8 months ago (2013-04-02 10:20:57 UTC) #1
ahe
7 years, 8 months ago (2013-04-02 10:21:13 UTC) #2
ahe
Rico is on vacation, Martin, could you take a look?
7 years, 8 months ago (2013-04-02 11:30:02 UTC) #3
kustermann
lgtm, since the warnings should be gone after the co19 update and we need to ...
7 years, 8 months ago (2013-04-02 11:40:02 UTC) #4
ahe
I can confirm that the warnings disappear when updating to co19 r512 (which I'm currently ...
7 years, 8 months ago (2013-04-02 11:56:37 UTC) #5
ahe
Committed patchset #1 manually as r20778 (presubmit successful).
7 years, 8 months ago (2013-04-02 14:10:11 UTC) #6
Ivan Posva
7 years, 8 months ago (2013-04-02 15:06:57 UTC) #7
Message was sent while issue was closed.
On 2013/04/02 11:56:37, ahe wrote:
> I can confirm that the warnings disappear when updating to co19 r512 (which
I'm
> currently working on).

Looking forward to a new drop of co19...

Thanks,
-Ivan

Powered by Google App Engine
This is Rietveld 408576698