Issue 1346273005: mark two tests as slow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1346273005: mark two tests as slow (Closed)

Created:
5 years, 3 months ago by sethladd

Modified:
5 years, 3 months ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/crypto.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

mark two tests as slow BUG= R=whesse@google.com Committed: https://github.com/dart-lang/crypto/commit/28dcddf3d41535a59492dd82b040ca267fb56ba7

Patch Set 2 : tweaks from review #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	.status	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Bill Hesse

LGTM with changes. https://codereview.chromium.org/1346273005/diff/1/.status File .status (right): https://codereview.chromium.org/1346273005/diff/1/.status#newcode13 .status:13: test/sha1_test.dart: SLOW Actually, it should be ...

5 years, 3 months ago (2015-09-18 18:21:36 UTC) #3

sethladd

5 years, 3 months ago (2015-09-18 18:25:55 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
28dcddf3d41535a59492dd82b040ca267fb56ba7 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 1346273005: mark two tests as slow (Closed)

Description

Patch Set 1 #

Patch Set 2 : tweaks from review #

Messages