Issue 1346203003: Isolate::Init() can return NULL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1346203003: Isolate::Init() can return NULL (Closed)

Created:
5 years, 3 months ago by zra

Modified:
5 years, 3 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Isolate::Init() can return NULL It can return NULL if someone tries to start a new isolate while the VM is shutting down. This change fixes flakes in //runtime/tests/vm/dart/spawn_shutdown_test.dart BUG= R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/8e68b67430a3c29c86711e2a4534e5c831ede3e8

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	runtime/vm/dart.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

zra

5 years, 3 months ago (2015-09-16 16:35:35 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
8e68b67430a3c29c86711e2a4534e5c831ede3e8 (presubmit successful).