Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1346093003: Revert "Add optional message to assert in Dart2js - continued" (Closed)

Created:
5 years, 3 months ago by sra1
Modified:
5 years, 3 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Add optional message to assert in Dart2js - continued" To be re-applied with .status changes. TBR=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/37be70525b1fd8401335a31ce219e74eb5d587c5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+298 lines, -401 lines) Patch
M pkg/compiler/lib/src/closure.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/common/backend_api.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/common/codegen.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/common/registry.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/common/resolution.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/placeholder_collector.dart View 2 chunks +4 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/inferrer_visitor.dart View 2 chunks +11 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart View 1 chunk +14 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 4 chunks +6 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/parser/listener.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/parser/node_listener.dart View 1 chunk +5 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/parser/parser.dart View 1 chunk +3 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 3 chunks +32 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/resolution/registry.dart View 2 chunks +7 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution_result.dart View 2 chunks +10 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor.dart View 1 chunk +26 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart View 3 chunks +25 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/send_structure.dart View 1 chunk +29 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/tree_elements.dart View 3 chunks +13 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 3 chunks +20 lines, -31 lines 0 comments Download
M pkg/compiler/lib/src/tree/nodes.dart View 3 chunks +0 lines, -26 lines 0 comments Download
M pkg/compiler/lib/src/tree/prettyprint.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/tree/unparser.dart View 1 chunk +0 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/typechecker.dart View 3 chunks +23 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/universe/selector.dart View 2 chunks +6 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/world.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/js_helper.dart View 2 chunks +10 lines, -32 lines 0 comments Download
M sdk/lib/core/errors.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/analyze_unused_dart2js_test.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/backend_dart/dart_printer_test.dart View 1 chunk +2 lines, -7 lines 0 comments Download
M tests/compiler/dart2js/js_backend_cps_ir.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 4 chunks +0 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/mock_libraries.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test_send_data.dart View 1 chunk +12 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test_send_visitor.dart View 1 chunk +18 lines, -0 lines 0 comments Download
D tests/compiler/dart2js/type_inference7_test.dart View 1 chunk +0 lines, -79 lines 0 comments Download
D tests/compiler/dart2js_extra/assert_with_message_test.dart View 1 chunk +0 lines, -108 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sra1
Committed patchset #1 (id:1) manually as 37be70525b1fd8401335a31ce219e74eb5d587c5 (presubmit successful).
5 years, 3 months ago (2015-09-16 23:37:22 UTC) #1
Siggi Cherem (dart-lang)
5 years, 3 months ago (2015-09-17 20:09:01 UTC) #2
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698