Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 13460008: - Mark more tests as unnecessarily slow. (Closed)

Created:
7 years, 8 months ago by Ivan Posva
Modified:
7 years, 8 months ago
Reviewers:
ricow1, nweiz, srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

- Mark more tests as unnecessarily slow. Committed: https://code.google.com/p/dart/source/detail?r=20796

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M pkg/pkg.status View 1 chunk +3 lines, -0 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
Ivan Posva
I am hoping that the suggestions in issue 9231 can be quickly applied to avoid ...
7 years, 8 months ago (2013-04-02 16:42:28 UTC) #1
Ivan Posva
TBR
7 years, 8 months ago (2013-04-02 16:42:46 UTC) #2
Ivan Posva
Committed patchset #1 manually as r20796 (presubmit successful).
7 years, 8 months ago (2013-04-02 16:42:58 UTC) #3
srdjan
lgtm
7 years, 8 months ago (2013-04-02 16:52:47 UTC) #4
nweiz
7 years, 8 months ago (2013-04-02 18:48:52 UTC) #5
Message was sent while issue was closed.
https://codereview.chromium.org/13460008/diff/1/pkg/pkg.status
File pkg/pkg.status (right):

https://codereview.chromium.org/13460008/diff/1/pkg/pkg.status#newcode16
pkg/pkg.status:16: # collections of tests. See meta bug 9231
Only scheduled_test_test and possibly descriptor_test have a large number of
test cases. scheduled_server_test and scheduled_process_test both have a
reasonable number of test cases.

Powered by Google App Engine
This is Rietveld 408576698